-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations for Menu and Menu Items #11827
Draft
rafalkosla101
wants to merge
102
commits into
feature/mobility_gem
Choose a base branch
from
feature/menu_translations
base: feature/mobility_gem
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c.rb Co-authored-by: Rafał Cymerys <rafal@upsidelab.io>
Locale in user
…roperty (#11831) Co-authored-by: aryt <adrianryt3@gmail.com> Co-authored-by: adrianryt <adrianryt3@gmal.com> Co-authored-by: Rafal Kosla <rafalkosla101@gmail.com>
add sudo apt-get update before install libvips
… name and provider columns.
Export products to rss
…onfigurations Remove unnecessary build configurations
# Conflicts: # core/brakeman.ignore # core/db/migrate/20230103144439_create_option_type_translations.rb # core/db/migrate/20230103151034_create_option_value_translations.rb # core/db/migrate/20230109084253_create_product_property_translations.rb # core/db/migrate/20230109105943_create_property_translations.rb
We decided not to merge it right now, since adding content translations to 4.6 is a big change already. Menu and CmsPage entities are already translatable, just not via mobility. I think we should get back to that in further versions and unify the structure then. |
nciemniak
changed the title
WIP Add menus to translatable resources
Translations for Menu and Menu Items
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu and Menu Item translations via Mobility.
Remaining to do: